feat: add option to bind outgoing connections to a specific interface#185
feat: add option to bind outgoing connections to a specific interface#185shahradelahi wants to merge 2 commits intom13253:masterfrom
Conversation
This adds a new `interface` configuration option to `doh-client` that allows users to specify a network interface for all outgoing DNS queries (including bootstrap and passthrough traffic).
|
I super love this feature. Please give me some time to review this. By the way, does it work correctly on dual-stack networks? I remembr Golang’s HTTP client uses Happy Eyeballs algorithm. (I could be wrong.) Is this new function compatible with it? |
|
I totally forgot about that. You're right, binding to a specific local IP breaks the default Happy Eyeballs behavior. I'll update the PR with a custom |
|
@vinnyperella Sorry to disturb you. I am considering to combining this new feature along #186 in the upcoming release but I currently don’t have enough time to test it throughoutly to make sure it doesn’t break anyone’s setup. |
@m13253 no worries but unfortunately I do not have a machine with multiple NIC's but I can see if I can aquire one I'd be more than happy to test. |
If we consider |
Well in that case yes I can test it I thought you meant an additional hardware NIC I'll try and get it set up in the next day or so. |
3 participants
This adds a new
interfaceconfiguration option todoh-clientthat allows users to specify a network interface for all outgoing DNS queries (including bootstrap and passthrough traffic).